-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apollo router integration example #162
Comments
Hey @tot-ra, i found this issue and was wondering if you've mad some progress on this. I was wondering if it'd make sense to have an endpoint that composes the supergraph within the registry and then just returns the composed supergraph. is there any way i could support here? |
We have done just that in our forked version of the registry in order to support GraphQL Federation v2. We have added an API endpoint that returns the fully built supergraph. This removes a fair amount of logic from our GraphQL Gateway as it does not have to build the supergraph anymore. It just has to call the registry's API to fetch the latest supergraph, which is then ready to serve. I had on my todo list to propose this feature back here, just haven't had the time. I could try and find some time to open a PR. |
@ehardy We've been working on a similar thing where the router directly connects to the registry and requests the full supergraph. It's been working well until we tried to upgrade the router to 1.12.0 because of the new entitlements. |
@flou We haven't faced such an issue since we are not using Router yet. We are still using a node.js based GraphQL Gateway. We are planning to move to Router though. Could you expand on the issue with entitlements? |
@ehardy After digging a bit more it turns out that it's not blocking anything. The entitlements are a way for the router to restrict the usage of enterprise features (like external cache, JWT auth and coprocessors), the router does that by sending a request to the registry asking for a new type which contains an entitlement with a signed JWT. I didn't closely enough at first but the entitlement field in the response of the registry can be omitted, and in that case the router is able to start without restricted features. |
No description provided.
The text was updated successfully, but these errors were encountered: