From 34dc5bbbd823654045ca31b107f97bc9f51c18b0 Mon Sep 17 00:00:00 2001 From: Matt Gabrenya Date: Thu, 8 Feb 2024 21:08:12 -0700 Subject: [PATCH 1/2] feat: dispatch event 'ready' when editorview initialized --- src/lib/CodeMirror.svelte | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lib/CodeMirror.svelte b/src/lib/CodeMirror.svelte index 523fdcd..31702d0 100644 --- a/src/lib/CodeMirror.svelte +++ b/src/lib/CodeMirror.svelte @@ -36,6 +36,7 @@ const is_browser = typeof window !== "undefined"; const dispatch = createEventDispatcher<{ change: string }>(); + const dispatchReady = createEventDispatcher<{ ready: string }>(); let element: HTMLDivElement; let view: EditorView; @@ -56,7 +57,10 @@ $: on_change = nodebounce ? handle_change : debounce(handle_change, 300); - onMount(() => (view = create_editor_view())); + onMount(() => { + view = create_editor_view(); + dispatchReady(view); + }); onDestroy(() => view?.destroy()); function create_editor_view(): EditorView { From c76b552350c16df5be7f97b43d5a9979a9ffe9f4 Mon Sep 17 00:00:00 2001 From: Matt Gabrenya Date: Thu, 8 Feb 2024 21:25:44 -0700 Subject: [PATCH 2/2] fix: use same event dispatcher --- src/lib/CodeMirror.svelte | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib/CodeMirror.svelte b/src/lib/CodeMirror.svelte index 31702d0..a625531 100644 --- a/src/lib/CodeMirror.svelte +++ b/src/lib/CodeMirror.svelte @@ -35,8 +35,7 @@ export let nodebounce = false; const is_browser = typeof window !== "undefined"; - const dispatch = createEventDispatcher<{ change: string }>(); - const dispatchReady = createEventDispatcher<{ ready: string }>(); + const dispatch = createEventDispatcher<{ change: string, ready: EditorView }>(); let element: HTMLDivElement; let view: EditorView; @@ -59,7 +58,7 @@ onMount(() => { view = create_editor_view(); - dispatchReady(view); + dispatch('ready', view); }); onDestroy(() => view?.destroy());