-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify the location of TLS certificate and host name to use. #86
Comments
For configurations such as this we currently recommend using TLS with the frontend/proxy you're currently using to manage certificates (such as Traefik, another nginx instance, etc) and they connect that frontend to WIS via HTTP. This isn't ideal from a networking standpoint but many users have already implement frontends such as this for their HA instance (as one example). That said this is pretty basic functionality that should be supported. However, to my knowledge nginx doesn't natively allow for the configuration file to access environment variables. We would have to add another step using envsubst or something like it to generate the config file on the fly from a template with environment variables. |
Yes, I'd love to do just that actually (via Apache as it's the one I'm already using). |
Yes, it's only currently available in wisng but we've done a lot of testing internally and with a few users. It's very stable but it hasn't been merged to main because we haven't quite tested as much as I would like and it's still developing fairly rapidly. |
Well, if you don't mind, I'll stay on the "master" branch until I have figured out my "stuck in P0" issue. |
No worries. The actual WIS config hasn't changed that much in wisng, the big change is the nginx frontend for socket handling. |
I have just pulled the latest main and I believe the
I'm not sure this is enough, or meant to be used like that so please let me know |
Right now, the
run.sh
script assumeskey.pem
andcert.pem
live next to it and that they apply to the hostname of the machine where the container will start.However, this may not always be the case, especially when the server is located in a DMZ with NAT allowing it to be reached via different names.
In my case, the machine is named
server
but is only reachable viawillow.domain.com
And for this FQDN, I already have a Let's Encrypt certificate that matches and is used by various other services.
I know I could use a symbolic link that points towards the appropriate files, but that means a reliance on filesystem functionality when I already have an environment file that sets the appropriate values for other services.
It would thus be really nice if one would be able to specify the location of the two certificate files from the
.env
file that issource
d into the script.And for the certificate to be accepted, I believe the process should also be told to expect connections from
willow.domain.com
and the machine hostname (server
)Note that removing TLS requirements altogether as in #82 would also be good in my case as both WIS and the Willow device live in the same private and secluded network and would happily talk to each other without any access to the outside world.
The text was updated successfully, but these errors were encountered: