Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dead code warning when default features are turned off. #783

Open
tobz opened this issue Aug 13, 2024 · 3 comments · May be fixed by #799
Open

Fix dead code warning when default features are turned off. #783

tobz opened this issue Aug 13, 2024 · 3 comments · May be fixed by #799
Assignees
@bp7968h
Labels
A-tower Area: the tower crate itself E-easy Call for participation: Experience needed to fix: Easy / not much P-low Low priority

Comments

@tobz
Copy link
Member

tobz commented Aug 13, 2024

There's a warning about Sealed (in tower) not being used when default features are disabled, as seen here: https://github.com/tower-rs/tower/actions/runs/10373855535/job/28719943265#step:5:72

We should fix that.
@tobz tobz added A-tower Area: the tower crate itself P-low Low priority E-easy Call for participation: Experience needed to fix: Easy / not much labels Aug 13, 2024
@bp7968h
Copy link

bp7968h commented Oct 25, 2024

Hi @tobz , can this be assigned to me please.

@tobz
Copy link
Member Author

tobz commented Oct 26, 2024

Sure, all yours. 👍🏻

@bp7968h bp7968h linked a pull request Oct 26, 2024 that will close this issue
Open
@bp7968h
Copy link

bp7968h commented Oct 26, 2024

Hi @tobz , I’ve linked the PR. Could you please review it, and your feedback is welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bp7968h bp7968h

Labels
A-tower Area: the tower crate itself E-easy Call for participation: Experience needed to fix: Easy / not much P-low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix dead code warning for 'Sealed' trait and 'sample_floyd2' func bp7968h/tower
2 participants
@tobz @bp7968h