Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Lines overlapping in certain keyframe situations #9

Open
Gebbi opened this issue Apr 24, 2017 · 1 comment
Open

Lines overlapping in certain keyframe situations #9

Gebbi opened this issue Apr 24, 2017 · 1 comment

Comments

@Gebbi
Copy link

Gebbi commented Apr 24, 2017

When using scenetiming and linking together, lines will overlap in this situation:

[Line1]....... [Line2]..|KF|..... [Line3]

--> Linking
[Line1].......[Line2]..|KF|.....[Line3]

--> Scenetiming
[Line1].......[Line2 + Line1-Overlap]..|KF + Line1-End|.....[Line3]

According to subs.py linking happens before scenetiming, which should be the source for this behavior. Simply switching both seems to fix it, but might have other implications though.

Example SRT:

1
00:21:51,920 --> 00:21:54,631
Line 1

2
00:21:54,798 --> 00:21:57,259
Line 2 (snaps to keyframe)

3
00:21:57,425 --> 00:22:01,805
Line 3 (overlaps to line 2 due to previous linking)

4
00:22:01,930 --> 00:22:06,685
Line 4

Example keyframes:

example_keyframes.txt

@Gebbi
Copy link
Author

Gebbi commented May 5, 2017

Note:
--kf-after-end has to be at least 300 for the problem to trigger in this example case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant