build: enable -Wall and -Werror

gotthardp · gotthardp · commit c3a8758cad15 · 2024-12-23T14:43:21.000+01:00
Fixes #86
diff --git a/Makefile.am b/Makefile.am
@@ -38,7 +38,7 @@ else
 @CODE_COVERAGE_RULES@
 endif
 
-COMMON_CFLAGS = $(CRYPTO_CFLAGS)
+COMMON_CFLAGS = -Werror -Wall $(CRYPTO_CFLAGS)
 COMMON_LDFLAGS =
 if WITH_ASAN
 COMMON_CFLAGS += -O1 -g -fsanitize=address -fno-omit-frame-pointer
diff --git a/src/tpm2-provider-cipher.c b/src/tpm2-provider-cipher.c
@@ -56,7 +56,7 @@ tpm2_cipher_all_newctx(void *provctx,
 }
 
 #define IMPLEMENT_CIPHER_NEWCTX(alg,kbits,amode,blkbits) \
-    static OSSL_FUNC_cipher_newctx_fn tpm2_cipher_##alg##kbits##lcmode##_newctx; \
+    static OSSL_FUNC_cipher_newctx_fn tpm2_cipher_##alg##kbits##amode##_newctx; \
     static void * \
     tpm2_cipher_##alg##kbits##amode##_newctx(void *provctx) \
     { \
diff --git a/test/ec_genpkey_store_load.c b/test/ec_genpkey_store_load.c
@@ -96,7 +96,7 @@ int sign_message(EVP_PKEY *pkey)
 
 int load_and_sign(const char *filename, const char *password)
 {
-    OSSL_STORE_CTX *ctx;
+    OSSL_STORE_CTX *ctx = NULL;
     UI_METHOD *ui_method = NULL;
     int ret = 1;
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ tpm2_cipher_all_newctx(void *provctx,`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`#define IMPLEMENT_CIPHER_NEWCTX(alg,kbits,amode,blkbits) \`
`59`		`- static OSSL_FUNC_cipher_newctx_fn tpm2_cipher_##alg##kbits##lcmode##_newctx; \`
	`59`	`+ static OSSL_FUNC_cipher_newctx_fn tpm2_cipher_##alg##kbits##amode##_newctx; \`
`60`	`60`	`static void * \`
`61`	`61`	`tpm2_cipher_##alg##kbits##amode##_newctx(void *provctx) \`
`62`	`62`	`{ \`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ int sign_message(EVP_PKEY *pkey)`
`96`	`96`
`97`	`97`	`int load_and_sign(const char filename, const char password)`
`98`	`98`	`{`
`99`		`- OSSL_STORE_CTX *ctx;`
	`99`	`+ OSSL_STORE_CTX *ctx = NULL;`
`100`	`100`	`UI_METHOD *ui_method = NULL;`
`101`	`101`	`int ret = 1;`
`102`	`102`