Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prone X Offset slider #451

Open
wyretm opened this issue May 20, 2024 · 7 comments
Open

Prone X Offset slider #451

wyretm opened this issue May 20, 2024 · 7 comments

Comments

@wyretm
Copy link

wyretm commented May 20, 2024

Would be nice to have since should the player size be larger than usual, via Pehkui or anything else, this becomes your view while prone
2024-05-20_14 59 54

Otherwise lovely mod, can't play without it.

@tr7zw
Copy link
Owner

tr7zw commented May 20, 2024

This mod doesnt touch the camera. So if the model height != the camera height, yeah this will happen. In the past I did add some workaround for Pehkui breaking sneaking in general, possible they changed something again.

@wyretm
Copy link
Author

wyretm commented May 20, 2024

Thanks for the quick response, I understand that this mod doesn't move the camera, what I was suggesting is the ability to adjust X Offset for the prone position, the same way you can for standing and sitting.

@tr7zw
Copy link
Owner

tr7zw commented May 20, 2024

The x offset is adjusted and has a slider. Pehkui breaks other mods so they don't know the player is actually sneaking, so Pehkui can do their own offset logic, which in return breaks this mod. 1.20.6 has player scaling built in, so mods like Pehkui are hopefully not required anymore, causing this issue. (Tho I'll have to be honest, kinda forgot to test if everything works correctly before releasing the update)

@wyretm
Copy link
Author

wyretm commented May 20, 2024

To clarify as it seems there's a bit of a misunderstanding happening, I'm not talking about sneaking, I'm referring to being prone, as in lying on the ground. In any case I'm not going to bother you further, thank you for your work.

@tr7zw
Copy link
Owner

tr7zw commented May 20, 2024

Ah, so you mean the "swimming on land"(literally what it is in terms of what Minecraft thinks, there is no "prone" code/logic). That might actually be something to look into. Then I assume swimming is affected the same way(at least when swimming straight, not up/down)?

@wyretm
Copy link
Author

wyretm commented May 20, 2024

Yes, sorry for the confusion, and yes normal swimming is also affected.

@tr7zw
Copy link
Owner

tr7zw commented May 20, 2024

Ok yea then I need to look it. Tho 1.20.6's native entity scaling will take priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants