Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic mode altitude threshold #483

Open
neirenoir opened this issue Aug 2, 2024 · 3 comments
Open

Dynamic mode altitude threshold #483

neirenoir opened this issue Aug 2, 2024 · 3 comments

Comments

@neirenoir
Copy link

neirenoir commented Aug 2, 2024

I would like to request the possibility of configuring the near and far values for dynamic mode's vanilla hands setting to choose at which angle the vanilla hands start hiding and when are they fully hidden. Many gun mods work just well with this mod if vanilla hands are enabled, but:

  • Vanilla hands always look wonk whenever you are looking down (i.e. right arm coming out of your left socket)
  • Dynamic mode starts hiding arms almost right after looking below 0° altitude, so aiming slightly downwards hides the gun

This could be solved by tweaking the values of when to enter dynamic mode and how long should it take to hide the vanilla hands completely. Requiring -30° or so to start hiding the arms could fix the problem.

@tr7zw
Copy link
Owner

tr7zw commented Aug 2, 2024

Disable dynamic mode if you want to use gun mods. As with all the other issues with gun mods, they are not and can't be better supported. Changing the angle doesn't work as you then would see your arm being dislocated when it tries to "come into view" and/or see your firstperson arms and the 3rd person arms at the same time, and/or see the 3rd person arms pop into view.

@neirenoir
Copy link
Author

Changing the angle doesn't work as you then would see your arm being dislocated when it tries to "come into view"

I mean, it beats having your arm dislocated all the time when looking down with vanilla hands.

Where is the dynamic mode code located in the repo? I can try giving a shot at a config option for this.

@tr7zw
Copy link
Owner

tr7zw commented Aug 2, 2024

https://github.com/tr7zw/FirstPersonModel/blob/main/src/main/java/dev/tr7zw/firstperson/mixins/HeldItemRendererMixin.java#L62
https://github.com/tr7zw/FirstPersonModel/blob/main/src/main/java/dev/tr7zw/firstperson/mixins/LivingEntityRendererMixin.java#L81

Have fun playing around with the values, but I think it will look really bad, worse than using vanilla hands or just not combining firstperson mod with gun mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants