Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21] Sneaking on ladder doesn't prevent cape from shifting. #198

Open
Ampflower opened this issue Jul 21, 2024 · 5 comments
Open

[1.21] Sneaking on ladder doesn't prevent cape from shifting. #198

Ampflower opened this issue Jul 21, 2024 · 5 comments

Comments

@Ampflower
Copy link

With quick code analysis, it seems that the CapeFeatureRenderer uses abstractCleintPlayerEntity.isInSneakingPose() rather than the model's sneaking field.

Likely a fairly simple redirect.

Have yet tested with an elytra.

@Ampflower
Copy link
Author

Evidently, that was for the angle of the cape, not the Y positioning; although it does make the cape less visually awkward.

@Ampflower
Copy link
Author

Come to realise it; the LadderAnimation does not seem to be properly applying a pose overwrite on 1.21, although it seems capable of overwriting the model's sneaking overwrite fine.

@tr7zw
Copy link
Owner

tr7zw commented Jul 21, 2024

Will have to look into it. Tbh had 0 time so far to play 1.21 myself.

@tr7zw
Copy link
Owner

tr7zw commented Dec 9, 2024

Hm, this has been fixed in 1.21.3+, but is broken for everything else 🤔. So probably broke during some refactoring.

Edit: The mixin is straight up not hooked up for anything other than 1.21.2+. Amazing.

@tr7zw
Copy link
Owner

tr7zw commented Dec 9, 2024

Ok I think I won't open this can of worms right now, 1.21.3+ has it fixed from there on. But turns out the head layers don't play nice with the head limiting, so that's something to fix before releasing the update.
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants