Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Addon conversion? #351

Closed
NullVoxPopuli opened this issue Oct 2, 2022 · 7 comments · Fixed by #384
Closed

V2 Addon conversion? #351

NullVoxPopuli opened this issue Oct 2, 2022 · 7 comments · Fixed by #384

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Oct 2, 2022

I'd like to convert this to a v2 addon, and I'd like to propose two paths:

  1. all at once
  2. 4 step process, as outlined on @ember/string
    1. switch to pnpm
    2. convert to monorepo
    3. create test-app
    4. move tests from v1 addon to test-app
    5. convert to v2 addon

Idk how much ya'll are familiar with v2 addon conversion, but the all at once PR, while way easier / faster, seems to scare folks not so familiar with the process. 😅

@chriskrycho
Copy link
Collaborator

I’ve landed a few. A PR is welcome (including if @SergeAstapov wants to do one of his amazing passes that way)! Just not yet at the top of the priority list to do myself.

@chriskrycho
Copy link
Collaborator

And to clarify: option (1) is totally fine!

@chriskrycho
Copy link
Collaborator

…fair warning: we need to get CI passing against Ember v4 first. It should be super easy, it just hasn’t, again, been at the top of the priority list yet. (It will be next week, though, b/c we’ll want it unblocked for work.)

@SergeAstapov
Copy link
Collaborator

@chriskrycho sure, would be glad to. might be good to starting point to warm and get little more active with contribution 🤪

@SergeAstapov
Copy link
Collaborator

for the info, I'm always in favor of path 2 as it's easier to handle one thing at a time and less chance to break things accidentally

@SergeAstapov
Copy link
Collaborator

I've started with making CI green, then doing slated breaking changes (dropping older Node.js + Ember versions support) and next thing will work on monorepoification followed by v2 addon conversion

@SergeAstapov SergeAstapov linked a pull request Nov 10, 2022 that will close this issue
@SergeAstapov
Copy link
Collaborator

SergeAstapov commented Nov 10, 2022

@NullVoxPopuli @chriskrycho v0.7.0 published to npm 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants