-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 Addon conversion? #351
Comments
I’ve landed a few. A PR is welcome (including if @SergeAstapov wants to do one of his amazing passes that way)! Just not yet at the top of the priority list to do myself. |
And to clarify: option (1) is totally fine! |
…fair warning: we need to get CI passing against Ember v4 first. It should be super easy, it just hasn’t, again, been at the top of the priority list yet. (It will be next week, though, b/c we’ll want it unblocked for work.) |
@chriskrycho sure, would be glad to. might be good to starting point to warm and get little more active with contribution 🤪 |
for the info, I'm always in favor of path 2 as it's easier to handle one thing at a time and less chance to break things accidentally |
I've started with making CI green, then doing slated breaking changes (dropping older Node.js + Ember versions support) and next thing will work on monorepoification followed by v2 addon conversion |
@NullVoxPopuli @chriskrycho v0.7.0 published to npm 🎉 |
I'd like to convert this to a v2 addon, and I'd like to propose two paths:
@ember/string
Idk how much ya'll are familiar with v2 addon conversion, but the all at once PR, while way easier / faster, seems to scare folks not so familiar with the process. 😅
The text was updated successfully, but these errors were encountered: