Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new language is cumbersome #660

Closed
ntd opened this issue Dec 2, 2020 · 8 comments
Closed

Adding a new language is cumbersome #660

ntd opened this issue Dec 2, 2020 · 8 comments

Comments

@ntd
Copy link

ntd commented Dec 2, 2020

I'm not really fond of transifex, so I'm possibly doing something terribly wrong on my side.

I usually add italian translations to SilverStripe modules via transifex without (much) prolems. With silverstripe-fluent though I met the following issue:

  1. there is no italian translation and I cannot create a new one, so I had to Request language;
  2. I'm part of the SilverStripe team (whatever this means) but silverstripe-fluent is not part of that team (it seems to be part of the silverstripe-fluent team);
  3. to join the silverstripe-fluent team I need to specify a language, and I still cannot join it until (1) is resolved.
    This seems to put a barrier to new contributions, objectively a light one but still a barrier. If this is by design, fill free to close this issue as WONTFIX.
@tractorcow
Copy link
Collaborator

hi @ntd ,

I'm going to let anyone who feels like it add their localisations directly to the module. :) I can take responsibility for syncing these up with the transifex source if that helps you out.

@tractorcow
Copy link
Collaborator

If you think this is a good idea, I'll add a contributing localisations note to the readme.md.

@ntd
Copy link
Author

ntd commented Dec 3, 2020

I'm going to let anyone who feels like it add their localisations directly to the module.

Do you mean by accepting PR? I thought this could be solved by just flipping a couple of switches on the transifex admin panel (just speculating: I never seen it) but of course also accepting PR will make this issue vanish instantly.

In my specific case, just let me know if I can make a PR or if you prefer the transifex approach, in which case you should do something on your side because I still don't see the italian language :)

transifex

@ntd
Copy link
Author

ntd commented Dec 5, 2020

2\. I'm part of the `SilverStripe` team (whatever this means) but `silverstripe-fluent` is not part of that team (it seems to be part of the `silverstripe-fluent` team);

Disregard this part: although I can translate almost all SilverStripe modules without issues, there are some (e.g. silvestripe-asset-admin) that behave like silverstripe-fluent, i.e. I cannot translate them until I "join the team". Likely in that case, the italian language is present so I can apply.

@tractorcow
Copy link
Collaborator

Sorry about all of these issues; SilverStripe actually control this account (who I am a member of still) so you are able to reach out to anyone there as well if you need help with permissions. :)

cc @chillu @unclecheese

@robbieaverill
Copy link
Contributor

I've approved all the requests I saw and invited you to the project @ntd

@ntd
Copy link
Author

ntd commented Dec 9, 2020

Thank you @robbieaverill, now everything seems to be working properly on transifex.

@tractorcow many thanks for your support: I will use transifex from now on. I think this issue is still present for new locales but feel free to close it as actually this is a pure virtual problem ;)

@GuySartorelli
Copy link
Contributor

Closing as this seems to have been resolved.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants