Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The unconstrained-less-than analysis pass does not check if the input is constant #18

Open
fegge opened this issue Nov 13, 2023 · 0 comments

Comments

@fegge
Copy link
Collaborator

fegge commented Nov 13, 2023

The unconstrained-less-than analysis pass should check if the input evaluates to a constant value before emitting a warning.

In particular, warnings like the following do not make any sense.

warning: Inputs to `LessThan` need to be constrained to ensure that they are non-negative
   ┌─ /.../file.circom:72:28
   │
72 │         lt.in[1] <== 50 + 5;
   │                      ^^^^^^ `50 + 5` needs to be constrained to ensure that it is <= p/2.
   │
   = For more details, see https://github.com/trailofbits/circomspect/blob/main/doc/analysis_passes.md#unconstrained-less-than.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant