Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Collection's public interface #51

Open
keimlink opened this issue May 15, 2015 · 1 comment
Open

Reduce Collection's public interface #51

keimlink opened this issue May 15, 2015 · 1 comment

Comments

@keimlink
Copy link
Member

The Collection class has too many public attributes and methods which confuse users if they are using a Collection instance.

Attributes that should be private:

  • as_dict
  • as_list
  • element_base
  • element_class
  • fields
  • flat

Methods that should be private:

  • get_values
@keimlink keimlink added this to the 0.2.0 milestone May 15, 2015
@keimlink
Copy link
Member Author

element_class is actually just the name of the new Element class. So it should be renamed to element_class_name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant