Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

ssl and verify_mode fail when set as boolean values #75

Open
ilkkapeltola opened this issue Aug 26, 2022 · 2 comments
Open

ssl and verify_mode fail when set as boolean values #75

ilkkapeltola opened this issue Aug 26, 2022 · 2 comments

Comments

@ilkkapeltola
Copy link

I have this tap installed separately and in meltano.
I need to use the config parameters 'ssl' and 'verify_mode'.
When running the tap alone, my config looks like this:

{ "user": "username", "password": "password", "host": "my-host.com", "port": 12345, "ssl": "true", "verify_mode": "false", "auth_database": "admin", "database": "settings" }

And this works, but only if ssl and verify_mode parameters are set as strings "true" and "false". Setting them as boolean true and false does not work.

This used to work with meltano too, but now for some reason this doesn't.
If I dump the config from meltano for this tap, it shows that in the config JSON, these two parameters are booleans, not strings.

{ "user": "username", "password": "password", "host": "my-host.com", "port": 12345, "ssl": true, "verify_mode": false, "auth_database": "admin", "database": "settings" }

and thus, the connection times out.

@ilkkapeltola
Copy link
Author

Perhaps this is not an issue exactly, but something that could be improved so that both string and boolean values could work.
It's a bit confusing that they need to be strings.

@anden-akkio
Copy link

Also ran into this and it took me a while to figure out what was going on. Making them strings worked well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants