-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trap should be allowed to use a different detection map #391
Comments
I just wanted to add that I think this would be a very nice feature to include. Sources are much cleaner to extract from the non-pb corrected images, and this is a common method used to extract sources from images. I would argue for it to be above a low priority. |
Yes, it sounds like this is pretty useful. @gijzelaerr , initially I was confused over this too, but it's all tucked away under the 'sourcefinding' functionality (so no impact on the database code). Basically, for every observation we feed the sourcefinder two images, one primary-beam corrected and one not. The sourcefinder performs island-detection on the uncorrected image (flat noise-profile makes this easier) but then runs Gaussian fitting on the primary-beam corrected image (so correct flux values). Apparently this is already implemented in Pyse, but we'd need to figure out how to pair up images and pass them as a list to the sourcefinder appropriately. |
Not quite sure why this has been assigned to me, unless you were after more discussion... There is a slight difference what people are asking for, although in theory we could have both.
|
you marked it as high priority on you wiki page :) This is why i added you. not sure if you have seen it, you know assign multiple people to the same issue. |
This is an ongoing wish list item but not essential for R7. Moving to the long term milestone. |
I am a bit confused, is there a source-finding step in the TraP outside PySE? |
Basically the issue was that you could use a different image for detecting the sources and then extract the fluxes in the image you want to process. So it is still using PySE, but implementing the |
In the TraP the source finding step should be allowed to use a detection map different from the analysis map. The detection map should be the non-primary beam corrected output of the awimager.
This feature already exists for PySE but it is not usable within the TraP.
@jdswinbank: Dario, can you give us a use-case for this? Is it not covered by the 'monitoringlist' functionality?
The text was updated successfully, but these errors were encountered: