Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OL strip map line becomes translucent on NEW -> ALL transition #121

Open
idreyn opened this issue Sep 22, 2022 · 2 comments
Open

OL strip map line becomes translucent on NEW -> ALL transition #121

idreyn opened this issue Sep 22, 2022 · 2 comments
Labels
frontend Change to frontend code good first issue Good for newcomers

Comments

@idreyn
Copy link
Contributor

idreyn commented Sep 22, 2022

To reproduce:

  • Load the tracker
  • Move to OL
  • Switch from NEW to ALL trains

The strip map line will go translucent. This is a visual cue we use for the non-selected branch of GL and RL and should never happen on the OL.

Screen.Recording.2022-09-21.at.9.58.20.PM.mov
@idreyn idreyn added good first issue Good for newcomers javascript frontend Change to frontend code labels Sep 22, 2022
@colbychaskell
Copy link
Member

I would argue this isn't exactly a bug and it is just the state when no trains are selected.

For the Red and Green line it will highlight which path the currently selected train is on, but if no trains are selected nothing is highlighted. It makes sense to me that the whole line would be highlighted only if a train is selected on the Orange line.

@nathan-weinberg
Copy link
Member

Think I agree with @colbychaskell here - wdyt @idreyn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Change to frontend code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@idreyn @nathan-weinberg @colbychaskell