Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to register Ctrl/Alt/Shift as keybindings when RFP on firefox is set to True #360

Open
t3dium opened this issue May 30, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@t3dium
Copy link

t3dium commented May 30, 2023

(Description/title edited from the previous issue of requesting a keyboard binding)

When privacy.resistFingerprinting is set to True some keys such as alt, control and shift are unable to be registered in the custom hotkey for linguist.

@vitonsky
Copy link
Collaborator

Duplicate of #266

This feature already implemented, check section "Page translation" in preferences

image

@vitonsky vitonsky added the duplicate This issue or pull request already exists label May 30, 2023
@t3dium
Copy link
Author

t3dium commented May 30, 2023

Duplicate of #266

This feature already implemented, check section "Page translation" in preferences

image

Oh thats good, missed that option in settings. Im not sure if this is a bug but ctrl, shift and alt dont appear when trying to record a hotkey on firefox for me. Though i was able to get / ' working, which works fine for me. This also only affects firefox (i have arkenfox's userjs installed if thats relevant), and worked on a chromium based browser.

@t3dium
Copy link
Author

t3dium commented May 30, 2023

Yeah this only occurs when privacy.resistFingerprinting (included in arkenfox's userjs), is set to True on a firefox browser. When false, keybindings including ctrl/shift/alt, are able to be registered

@t3dium t3dium changed the title Keyboard shortcut to translate a page via linguist Ctrl/Alt/Shift not able to be registered as keybindings when RFP on firefox is set to True May 30, 2023
@t3dium t3dium changed the title Ctrl/Alt/Shift not able to be registered as keybindings when RFP on firefox is set to True Not able to register Ctrl/Alt/Shift as keybindings when RFP on firefox is set to True May 30, 2023
@vitonsky vitonsky added bug Something isn't working and removed duplicate This issue or pull request already exists labels May 30, 2023
@vitonsky
Copy link
Collaborator

It looks the problem could be solved with handle hotkeys by special WebExtension API.
I will keep in mind this problem and will fix it if we will have similar problems with shortcuts implemented on content script side.

Thank you for report, it's are worth contribution to problems knowledge base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants