Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded count went over total left #131

Closed
fineless71 opened this issue Sep 21, 2024 · 3 comments
Closed

Downloaded count went over total left #131

fineless71 opened this issue Sep 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@fineless71
Copy link

fineless71 commented Sep 21, 2024

I can't reproduce this but I'd figure I'd file a bug report: This happened to me again, but with a different song. Same symptoms, one of the duplicates is the very last one. Seems to happen ~50% of the time, maybe related to reloading but I'm not decently sure of the cause.

I pressed the "Download All Lyrics" button and it went past the max. (17/16)

image

Sorry for the censor: In the list, one of the songs is listed twice, one of them is at the end, and one is near the middle.

@fineless71
Copy link
Author

image
I used the "Download Album Lyrics" and I got this happen, the bottom song is not in the album. This was shortly after I cancelling a download for all songs. Sorry for the censor before as it included songs I didn't want to share.

@tranxuanthang tranxuanthang added the bug Something isn't working label Sep 28, 2024
@fineless71
Copy link
Author

fineless71 commented Oct 2, 2024

This is 100% an assumption and I have no idea how the code works, but my guess is that when stopping a mass download, it doesn't cancel the active web requests, so when you start a new download and then a request from the previous download finishes, it gets added to the current one

Edit: Nevermind, I tried with a long wait between downloads and this bug still happened.

@tranxuanthang
Copy link
Owner

I think I kind of fixed it in some recent commits, so allow me to close this issue for now in order to clean up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants