MacOS Installers #49
Merged
MacOS Installers #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most of the code is directly taken from the applecrate github repo. needs testing, i currently have no idea if this works at all. tests to be written once it actually works on macos...
- applecrate is used to package CLIs (works) - GUI: package `.app` by hand, then turn into dmg with dmgbuild
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 99.74% 99.76% +0.01%
==========================================
Files 24 25 +1
Lines 1581 1669 +88
==========================================
+ Hits 1577 1665 +88
Misses 4 4 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for creating installers for CLIs and GUIs on MacOS. Details and discussion are in comments on #33.
In brief:
applecratesand a.pkginstaller is created. This has issues (see docs).appfile and then creating a.dmgfile with an arrow toApplicationsfor installation (as used by macos) usingdmgbuild.Several improvements should take place here in the future:
dmgbuildThese improvements are not mandatory for a new release, since the basic prinicple is now working and we can improve from here.
Closes #33