Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get icon from any assets folder #50

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

trappitsch
Copy link
Owner

Icons can now live in any folder named assets, no matter where. This is useful for programs, where we want to package the icon along with the python package and use the same icon for the executable and the package. How to do this is also noted in the docs.

Updated changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (64e5a8f) to head (6d1497c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          25       25           
  Lines        1669     1707   +38     
=======================================
+ Hits         1665     1703   +38     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trappitsch trappitsch merged commit bc08b77 into main Jun 7, 2024
9 checks passed
@trappitsch trappitsch deleted the get_icon_from_any_assets_folder branch June 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants