Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linux GUI installer #51

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Improve linux GUI installer #51

merged 2 commits into from
Jun 7, 2024

Conversation

trappitsch
Copy link
Owner

Linux GUI uninstaller improvements.

  • Deletes the executable
  • Deletes the stored icon
  • Deletes the uninstaller itself
  • Then tries to delete the folder with rmdir, which will only succeed if it's empty at this point!

Only rm -rf used is for pyapp (which is tested for as well now).

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (bc08b77) to head (49b5eca).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          25       25           
  Lines        1707     1708    +1     
=======================================
+ Hits         1703     1704    +1     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trappitsch trappitsch merged commit 8e2e293 into main Jun 7, 2024
6 of 7 checks passed
@trappitsch trappitsch deleted the fix_linux_installer branch June 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants