Emojis not escaped in inline code blocks

[nicolasreich]

:helicopter: should not be translated to 🚁.

[travs]

@nicolasreich you can disable emojis in this package's settings as a workaround
@BlueHatbRit what do you think of this one? Should they be escaped or no?

[elliotblackburn]

The emoji module mdpdf is using is pretty primitive and was actually only just open sourced a little while ago with very little distinction. I'm not sure this is considered a "bug" in mdpdf but more a question of whether the feature should be changed.

In regards to markdown-pdf, what does the markdown preview show? I'm not an active atom user, so I'm not sure if any of their preview displays emojis at all actually. Comments on this would be great!

[travs]

@BlueHatbRit Ahh ok, understood. In atom it displays as :helicopter: without the emoji inside the code section

[elliotblackburn]

I've just had a look at the emoji plugin being used (https://github.com/Bloggify/showdown-emoji), it just goes through all markdown converting anything identified as an emoji and converts it, it has no restrictions around code blocks etc.

We might be able made a contribution to add this feature to it, I'm not very experienced with Showdowns extension API though so I don't know how much info the emoji extension is getting. I'll take a look and see if I can scope out an issue to raise and hopefully someone can hop on it.

At the moment this is not considered a bug in mdpdf or showdown-emoji, but could be a feature suggestion.

The author of the extension has been really great at the past with a few bugs so I'm sure they'd be open to talking about a configuration addition for this.

[travs]

@BlueHatbRit Awesome, and sounds good. Thanks for having a look!