Retry for 50X HTTP Status for GET, POST Methods

[kar0t]

Hi. Currently, the trino-client-ruby library only performs retries for 503 HTTP status codes.

However, according to the trino client protocol, it should also retry for 502 and 504.

• https://trino.io/docs/current/develop/client-protocol.html#overview-of-query-processing

If the client request returns an HTTP 502, 503, or 504, that means there was an intermittent problem processing request and the client should try again in 50-100 ms. Trino does not generate those codes by itself, but those can be generated by load balancers in front of Trino.

We would appreciate a code fix for this.

[yuokada]

@kar0t Thanks for sending the pull request.
The new package that includes your change is available.
https://rubygems.org/gems/trino-client/versions/2.2.1

[kar0t]

The Ruby Client has been modified to retry in case of GET failures, but the POST method does not yet retry.
I suggest a fix for this. Below is the POST Retry implementation in the Trino Python Client for reference.

• https://github.com/trinodb/trino-python-client/blob/8f5dfdfa507259f140163f9b144782442265c23b/trino/client.py#L531