Add support for "discard" keyword #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theHamsta
reviewed
Sep 23, 2023
| @@ -17,6 +17,20 @@ module.exports = grammar(C, { | |||
| ...original.members.filter((member) => member.content?.name != '_old_style_function_definition'), | |||
| ), | |||
|
|
|||
| _top_level_statement: (_, original) => choice( | |||
There was a problem hiding this comment.
yeah, this was the exact problem that got a similar change failing in HLSL. Should we really allow discard as a top-level statement? It actually only makes sense within a shader. This was one of the reasons why I didn't integrate the change myself.
What's your opinion on this? Should discard be allowed top-level for improved testing and error-recovery or only within shader functions?
theHamsta
reviewed
Sep 23, 2023
|
|
||
| ================================================================================ | ||
| Discard | ||
| ================================================================================ |
There was a problem hiding this comment.
You need to run tree-sitter test -u because there seems to be another test using discard, currently parsed as an expression_statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22. Note I haven't regenerated
src/parser.chere since that might introduce conflicts with #33 and #34 :) Thanks again!