Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: how can I PR an extension like tsx, but for another superset language? #307

Closed
1 task done
NullVoxPopuli opened this issue Aug 7, 2024 · 1 comment
Closed
1 task done

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Aug 7, 2024

Did you check the tree-sitter docs?

Is your feature request related to a problem? Please describe.

I've noticed that tree-sitter-javascript works fine for this "gjs" syntax, but "gts" falls over with an error:

image
image

My previous PRs to this repo were just around highlighting, but it's clear that I need to probably do some parsing work as well: #277

The code that supports this for javascript / the javascript flavor of glimmer, is not very big:
https://github.com/tree-sitter/tree-sitter-javascript/pull/208/files#diff-919ac210accac9ecc55a76d10a7590e3d85ca3f0e165b52d30f08faee486d0cbR547

does this need to be duplicated in to this repo for gts (Glimmer-flavored TypeScript) support?

Describe the solution you'd like

I can implement whatever, just need some guidance

Describe alternatives you've considered

n/a

Additional context

No response

@amaanq
Copy link
Member

amaanq commented Aug 17, 2024

Closing since we discussed the solution in #308

@amaanq amaanq closed this as completed Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants