Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation to Specify Java 8 for Maven Builds #8581

Open
Annaseli opened this issue Feb 2, 2025 · 0 comments
Open

Update Documentation to Specify Java 8 for Maven Builds #8581

Annaseli opened this issue Feb 2, 2025 · 0 comments
Labels
docs Improvements or additions to documentation

Comments

@Annaseli
Copy link
Contributor

Annaseli commented Feb 2, 2025

When running make test with Maven using Java 23, the following error occurs:

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.770 s
[INFO] Finished at: 2025-01-28T17:43:16+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project hadoop-lakefs: Compilation failure: Compilation failure: 
[ERROR] /Users/annaseliverstov/work/lakeFS/clients/hadoopfs/src/test/java/io/lakefs/FSTestBase.java:[320,57] cannot find symbol
[ERROR]   symbol:   class ImmutablePagination
[ERROR]   location: class io.lakefs.FSTestBase
[ERROR] /Users/annaseliverstov/work/lakeFS/clients/hadoopfs/src/test/java/io/lakefs/FSTestBase.java:[324,68] cannot find symbol
[ERROR]   symbol:   class ImmutablePagination
[ERROR]   location: class io.lakefs.FSTestBase

The failure occurs in the hadoopfs client tests. However, when using Java 8, the tests pass successfully.

Proposed Fix:

  1. Update the lakeFS Contributing Guide

    • Under Setting up an Environment, in the section on Maven, specify that Java 8 is required for building and testing the hadoopfs client.
  2. Update the README in clients/hadoopfs

    • Add a building section stating that Maven tests should be run with Java 8.
@Annaseli Annaseli added the docs Improvements or additions to documentation label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant