Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range and Metarange per StorageID #8595

Open
nadavsteindler opened this issue Feb 4, 2025 · 0 comments · May be fixed by #8600
Open

Range and Metarange per StorageID #8595

nadavsteindler opened this issue Feb 4, 2025 · 0 comments · May be fixed by #8600
Assignees

Comments

@nadavsteindler
Copy link
Contributor

nadavsteindler commented Feb 4, 2025

This came up during the tierfs issue #8546
The idea is to refactor ranges/metaranges to support a single StorageID

The changes here and in range_manager.go seem odd. AFAICT, a metarange from a storage backend will manage ranges from that same backend. So why not hold storage ID on the metarange and range managers? Everything on them is either externally owned (like TierFS) or reference-counted (like the pebble read cache, which we manage as "cache Unrefer"). So committedManager might hold a map from StorageID to their metarange and range managers. This would allow us to limit the spread of StorageIDs throughout the code.

Possible implementation: #8594

Tests for CommittedManager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant