Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Contribution Guide #105

Open
felipecosta09 opened this issue Nov 10, 2022 · 0 comments
Open

Improve Contribution Guide #105

felipecosta09 opened this issue Nov 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@felipecosta09
Copy link
Member

Problem to solve

During PR code review, multiple times changes are requested from the reviewer to jump one line after each end of the file that stores code. I'm assuming this is because of the POSIX format(Thanks @andresark for explaining to me what that is), but the lack of documentation and awareness about this standard makes the PR review very long. I understand the importance of using it, but the contributor should have this information beforehand so it can make it right from the first time.

Proposed solution

Update the Contribution Guide with these requirements so the contributor can make the PR already with these formats so we can make the PR review more straightforward and fast.

@felipecosta09 felipecosta09 added the enhancement New feature or request label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant