Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTI_STEP PLI PER_STEP FALSE causes crash #755

Closed
laurensvalk opened this issue Jul 8, 2024 · 3 comments
Closed

MULTI_STEP PLI PER_STEP FALSE causes crash #755

laurensvalk opened this issue Jul 8, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@laurensvalk
Copy link

Showing a single PLI for a multi step leads to a segfault, as shown below.

crash.mp4

example.mpd.txt

0 FILE main.ldr
0 main
0 Name: main.ldr
0 Author: Laurens Valk
0 Unofficial Model
0 ROTATION CENTER 0 0 0 1 "Custom"
0 ROTATION CENTER 0 0 0 1 "Custom"
0 ROTATION CONFIG 0 0
1 0 0 0 200 1 0 0 0 1 0 0 0 1 rear.ldr
1 15 -180 0 0 0 1 0 -1 0 0 0 0 1 48267.dat
1 0 -160 0 0 0 0 -1 0 1 0 1 0 0 39367p01.dat
0 STEP
0
0 NOFILE
0
0 FILE rear.ldr
0 New Model
0 Name: rear.ldr
0 Author: Laurens Valk
0 Unofficial Model
0 ROTATION CENTER 0 0 0 1 "Custom"
0 ROTATION CONFIG 0 0
0 !LPUB MULTI_STEP BEGIN
1 322 0 0 0 0 0 -1 0 1 0 1 0 0 39370c01.dat
1 99 40 0 -10 0 0 1 0 -1 0 1 0 0 3673.dat
1 99 40 -20 -10 0 0 1 0 -1 0 1 0 0 3673.dat
1 99 0 0 -10 0 0 1 0 -1 0 1 0 0 3673.dat
1 99 -40 0 -10 0 0 1 0 -1 0 1 0 0 3673.dat
1 99 -40 -20 -10 0 0 1 0 -1 0 1 0 0 3673.dat
0 ROTSTEP 30 -45 0 ABS
1 26 0 0 -20 0 0 1 -1 0 0 0 -1 0 32525.dat
1 26 0 -20 -20 0 0 1 -1 0 0 0 -1 0 32525.dat
1 99 100 0 -30 0 0 1 0 -1 0 1 0 0 3673.dat
1 99 -100 0 -30 0 0 1 0 -1 0 1 0 0 3673.dat
0 STEP
0 !LPUB MULTI_STEP END
1 71 -100 0 -40 1 0 0 0 -1 0 0 0 -1 48989.dat
1 71 100 0 -40 1 0 0 0 -1 0 0 0 -1 48989.dat
0 STEP
1 99 -90 20 -40 -1 0 0 0 -1 0 0 0 1 3673.dat
1 99 -90 -20 -40 -1 0 0 0 -1 0 0 0 1 3673.dat
1 99 90 -20 -40 -1 0 0 0 -1 0 0 0 1 3673.dat
1 99 90 20 -40 -1 0 0 0 -1 0 0 0 1 3673.dat
0 STEP
1 0 80 -60 -40 0 1 0 0 0 1 1 0 0 40490.dat
1 0 -80 -60 -40 0 1 0 0 0 1 1 0 0 40490.dat
0 STEP
0
0
0 NOFILE
0

I'll go back to verify on previous builds.


Unrelated: this project does not appear to have GitHub sponsors enabled. If you do, I think some people would be happy to chip in :)

@trevorsandy
Copy link
Owner

Thank you for reporting this behaviour. I'll take a look.

Cheers,

@trevorsandy trevorsandy moved this to IN PROGRESS in LPub3D Maintenance Sep 22, 2024
@trevorsandy trevorsandy added this to the 2.4.8 milestone Oct 8, 2024
@trevorsandy
Copy link
Owner

This behaviour has been corrected.

It is now possible to switch a multi-step 'PLI per step' page to 'PLI per page'. If the pre-defined relative positioning is not desirable, it is possible to drag the PLI, and subModel Preview if shown, to your desired location on the page. It is also possible to drag the step group to your desired location on the page.

PliPerStepCrash755

Note - to avoid frustration, when attempting to move the step group on a multi-step page, be sure to hover over the highlighted border until the 'tooltip' indicates 'Step Group', at this point, you can commence to drag the step group to the desired location. Note that all page items placed relative to the step group will also change position when the step group is moved.

Cheers,

@laurensvalk
Copy link
Author

laurensvalk commented Oct 8, 2024

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants