-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with rocksdb newer than 6.15.5 fails #617
Comments
Hm, it seems that |
There seems to be a PR addressing this, however, it seems a bit stale. |
Actually, the above mentioned PR never got to us. |
Great, let's track it here. Once blockbook gets upgraded to the newest go and rocksdb we can give it a go and fix NixOS/nixpkgs#122215 |
It seems there is a fork of gorocksdb called grocksdb https://github.com/linxGnu/grocksdb, which promises to better track RocksDB development. No idea how well battle-tested is this one, but the upstream seems active. |
Thank you. There is already this commit d5cff45 in the branch v0.3.6, which works with the newest RocksDB. I used a different fork and picked from it a commit which fixes only the issue with the new RocksDB but does not include any other changes from the fork to keep it simple and safe. But we can switch to the fork suggested by you if you prefer. The branch is not yet buildable using docker build, unfortunately, because of changes in go1.16 (something related to this https://stackoverflow.com/questions/66894200/go-go-mod-file-not-found-in-current-directory-or-any-parent-directory-see-go). I did not have time yet to fix it completely. |
I don't have strong preference for either, because I have not investigated this in depth. I just wanted to share what I found and I leave the final decision about which fork to use up to you, Martin. Thanks! |
I've seen this earlier. Probably setting one of the following will help:
|
RocksDB upgraded in v0.3.6 |
Hi @martinboehm !
Building blockbook with rocksdb newer than 6.15.5 seems to break the build. Is this a known issue / are there any plans on making it work with newer versions?
Thanks!
The text was updated successfully, but these errors were encountered: