Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): bump cffi to 0.17.1 #4476

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore(python): bump cffi to 0.17.1 #4476

merged 1 commit into from
Jan 7, 2025

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 7, 2025

most probably fix for #4474

@prusnak prusnak linked an issue Jan 7, 2025 that may be closed by this pull request
to support Python 3.13

[no changelog]
Copy link

github-actions bot commented Jan 7, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like.
@bosomt please test and close the issue if it helps

@matejcik matejcik merged commit d06382e into main Jan 7, 2025
93 of 95 checks passed
@matejcik matejcik deleted the python-bump-cffi branch January 7, 2025 19:44
@bosomt
Copy link

bosomt commented Jan 16, 2025

It didnt helped me ;(

❯ poetry install
The "poetry.dev-dependencies" section is deprecated and will be removed in a future version. Use "poetry.group.dev.dependencies" instead.
Installing dependencies from lock file

Package operations: 35 installs, 0 updates, 0 removals

  - Installing pillow (10.3.0): Failed

PEP517 build of a dependency failed

Backend subprocess exited when trying to invoke get_requires_for_build_wheel

    | Command '['/var/folders/w1/k59hb6y575dd_l15jdsfffq40000gq/T/tmpm8oplqpi/.venv/bin/python', '/opt/homebrew/Cellar/poetry/2.0.1/libexec/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py', 'get_requires_for_build_wheel', '/var/folders/w1/k59hb6y575dd_l15jdsfffq40000gq/T/tmpzswgksny']' returned non-zero exit status 1.
    |
    | Traceback (most recent call last):
    |   File "/opt/homebrew/Cellar/poetry/2.0.1/libexec/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    |     main()
    |     ~~~~^^
    |   File "/opt/homebrew/Cellar/poetry/2.0.1/libexec/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    |     json_out["return_val"] = hook(**hook_input["kwargs"])
    |                              ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/opt/homebrew/Cellar/poetry/2.0.1/libexec/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
    |     return hook(config_settings)
    |   File "/private/var/folders/w1/k59hb6y575dd_l15jdsfffq40000gq/T/tmpm8oplqpi/.venv/lib/python3.13/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
    |     return self._get_build_requires(config_settings, requirements=[])
    |            ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/private/var/folders/w1/k59hb6y575dd_l15jdsfffq40000gq/T/tmpm8oplqpi/.venv/lib/python3.13/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
    |     self.run_setup()
    |     ~~~~~~~~~~~~~~^^
    |   File "/private/var/folders/w1/k59hb6y575dd_l15jdsfffq40000gq/T/tmpm8oplqpi/.venv/lib/python3.13/site-packages/setuptools/build_meta.py", line 320, in run_setup
    |     exec(code, locals())
    |     ~~~~^^^^^^^^^^^^^^^^
    |   File "<string>", line 33, in <module>
    |   File "<string>", line 27, in get_version
    | KeyError: '__version__'

Note: This error originates from the build backend, and is likely not a problem with poetry but one of the following issues with pillow (10.3.0)

  - not supporting PEP 517 builds
  - not specifying PEP 517 build requirements correctly
  - the build requirements are incompatible with your operating system or Python version
  - the build requirements are missing system dependencies (eg: compilers, libraries, headers).

You can verify this by running pip wheel --no-cache-dir --use-pep517 "pillow (==10.3.0)".

    ~/Trezor/trezor-firmware  on   main 

@prusnak
Copy link
Member Author

prusnak commented Jan 17, 2025

  • Installing pillow (10.3.0): Failed

This is a different error -> PR in #4513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

not able to install poetry with python 3.13
3 participants