Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Solana deps from Suite to Connect #10907

Closed
marekrjpolak opened this issue Jan 30, 2024 · 1 comment · Fixed by #16208
Closed

Move Solana deps from Suite to Connect #10907

marekrjpolak opened this issue Jan 30, 2024 · 1 comment · Fixed by #16208
Assignees
@martykan
Labels
code Code improvements solana

Comments

@marekrjpolak
Copy link
Contributor

marekrjpolak commented Jan 30, 2024 •
edited
Loading

As stated here #9958 (review) and there, for security and optimization reasons we want to move all Solana 3rd party dependencies from Suite (probably mainly in solanaUtils) to Connect's api/solana/api subfolder.

It could mean to edit existing Solana-related methods and/or to create new solanaComposeTransaction method (similarly to cardanoComposeTransaction).
@marekrjpolak marekrjpolak added code Code improvements solana labels Jan 30, 2024
@MiroslavProchazka MiroslavProchazka moved this to 🎯 To do in Issues Suite Feb 5, 2024
@hynek-jina hynek-jina added this to Solana Feb 6, 2024
@tomasklim tomasklim moved this to To do 🎯 in Solana Dec 30, 2024
@martykan martykan mentioned this issue Jan 6, 2025
Merged
@tomasklim tomasklim moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Jan 9, 2025
@github-project-automation github-project-automation bot moved this from To do 🎯 to Approved ✅ in Solana Jan 14, 2025
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Jan 14, 2025
@bosomt
Copy link
Contributor

bosomt commented Jan 17, 2025

QA OK

  • discovery ✅
  • receive ✅
  • send SOL ✅ 0.000486216 SOL sent from Solana #2
  • send token ✅ 164691.3378 BONK sent from Solana #3
  • unstake ✅ 0.016530043 SOL unstaked
  • stake ✅ 0.01 SOL staked from Solana #1

Info:

  • Suite version: web 25.2.0 (275b92f)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martykan martykan

Labels
code Code improvements solana
Projects
Issues Suite
Status: ✅ Approved
Solana
Status: Approved ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(connnect): solanaComposeTransaction method trezor/trezor-suite
3 participants
@martykan @marekrjpolak @bosomt