Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable “Bump Fee” for txs with higher nonce than the lowest pending #13529

Closed
tomasklim opened this issue Jul 28, 2024 · 2 comments · Fixed by #14395
Closed

Disable “Bump Fee” for txs with higher nonce than the lowest pending #13529

tomasklim opened this issue Jul 28, 2024 · 2 comments · Fixed by #14395
Assignees

Comments

@tomasklim
Copy link
Member

tomasklim commented Jul 28, 2024

Users are currently experiencing difficulty determining which transaction to bump to ensure it gets confirmed. The current system can lead to confusion, as bumping the oldest transaction with a small fee may still not result in confirmation due the a fact that oldest tx (time) may not have lowest nonce (was already bumped once)

Solution to address this issue:

  1. Disable “Bump Fee” for txs with higher nonce: Only the bump button for the transaction with the lowest nonce should remain enabled. This will guide users to prioritize the oldest transaction first.
  2. Add Tooltips to Disabled Buttons: Implement tooltips on disabled buttons indicating that the user must first bump the fee for the transaction with the lowest nonce. This tooltip will provide clarity on the required action.

Possible downsides:

  1. In case user has all txs underprices, he has to wait for the oldest one to get confirmed to bump the rest. If that is problematic, we can introduce modal or add nonce to pending tx

Screenshot 2024-07-28 at 20 53 13

Please take in mind also this change which can make it even more confusing #12975

@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jul 28, 2024
@tomasklim tomasklim changed the title Disable bump fee for newer txs or find better solution for marking what tx has to be bumped first Disable “Bump Fee” for txs with higher nonce than the lowest pending Jul 29, 2024
@Lemonexe
Copy link
Contributor

If I understand correctly, this is only for ethereum-type networks, right?

@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Sep 19, 2024
@bosomt
Copy link
Contributor

bosomt commented Sep 23, 2024

QA OK

Image

Info:

  • Suite version: desktop 24.10.0 (0c147a1)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.10.0 Chrome/124.0.6367.243 Electron/30.3.1 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.3 regular (revision 7f373ae71eca855dd41b4a0fdcc7cadaa13a8281)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants