Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token outputs cannot be given labels. #7402

Closed
komret opened this issue Jan 17, 2023 · 4 comments
Closed

Token outputs cannot be given labels. #7402

komret opened this issue Jan 17, 2023 · 4 comments
Labels
bug Something isn't working as expected cardano Related to Cardano (ADA) blockchain platform EVM Issues related to networks based on Ethereum Virtual Machine

Comments

@komret
Copy link
Contributor

komret commented Jan 17, 2023

Describe the bug
The TokenTransfer component does not include MetadataLabeling which leads to token transfers not being able to have labels. Although a label can be added in send form when creating the transaction, it is never displayed. Affects both Ethereum and Cardano.

Expected behavior
Be able to add label to token outputs and display it in history.

Screenshots
https://user-images.githubusercontent.com/42465546/212911686-b7d56405-8de4-4f1f-8850-9950bf5a419f.mov
@komret komret added bug Something isn't working as expected ERC20 altcoins not related to bitcoin labels Jan 17, 2023
@hynek-jina hynek-jina added cardano Related to Cardano (ADA) blockchain platform EVM Issues related to networks based on Ethereum Virtual Machine and removed altcoins not related to bitcoin labels Jan 17, 2023
@mroz22
Copy link
Contributor

mroz22 commented Jan 18, 2023

#5155
never finished ...

@hynek-jina
Copy link
Contributor

Consider #7406

@bosomt
Copy link
Contributor

bosomt commented Mar 15, 2023

Duplicity ? #3545

@komret
Copy link
Contributor Author

komret commented Mar 15, 2023

Closing in favour of #3545.

@komret komret closed this as completed Mar 15, 2023
@github-project-automation github-project-automation bot moved this to 🤝 Needs QA in Suite Desktop Mar 15, 2023
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Mar 19, 2023
@tomasklim tomasklim removed the ERC20 label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected cardano Related to Cardano (ADA) blockchain platform EVM Issues related to networks based on Ethereum Virtual Machine
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hynek-jina @mroz22 @bosomt @tomasklim @komret