Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRI-4123] Logging objects with keys with periods in doesn't render properly in the UI #1510

Open
matt-aitken opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Nov 29, 2024

Problem

{
  "Key 0.002mm": 31.4,
}

In our dashboard this appears as:

{
  "Key 0": {
      "002mm": 31.4
  }
}

We flatten them to store in the database using . as the delimiter. These dots will need to be escaped/unescaped when flattening/unflattening.

This won't impact anything except the logs, we only flatten data there. It'll work fine in payloads and outputs.

Flatten code: https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/src/v3/utils/flattenAttributes.ts
Flatten tests: https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/test/flattenAttributes.test.ts

TRI-4123

@matt-aitken matt-aitken added the bug Something isn't working label Nov 29, 2024
@matt-aitken matt-aitken changed the title Logging objects with keys with periods in doesn't render properly in the UI [TRI-4123] Logging objects with keys with periods in doesn't render properly in the UI Nov 29, 2024
@yadavshubham01
Copy link
Contributor

hey @matt-aitken please review my PR #1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants