From 8639e294a71f29c8c918765aba610cd781112466 Mon Sep 17 00:00:00 2001 From: MinyazevR <89993880+MinyazevR@users.noreply.github.com> Date: Mon, 21 Oct 2024 13:25:17 +0300 Subject: [PATCH] Add ip address checker (#796) Add test and logging for invalid IP address --- trikNetwork/src/mailboxServer.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/trikNetwork/src/mailboxServer.cpp b/trikNetwork/src/mailboxServer.cpp index e0ad5032..5e19e607 100644 --- a/trikNetwork/src/mailboxServer.cpp +++ b/trikNetwork/src/mailboxServer.cpp @@ -103,6 +103,11 @@ void MailboxServer::setHullNumber(int hullNumber) void MailboxServer::connectTo(const QString &ip, int port) { + QHostAddress address; + if (!address.setAddress(ip)) { + QLOG_INFO() << "Connect to ip " << ip << "and port" << port << "with not valid ip"; + return; +; } mAuxiliaryInformationLock.lockForRead(); auto server = mServerIp; auto serverPort = mServerPort; @@ -111,7 +116,12 @@ void MailboxServer::connectTo(const QString &ip, int port) if (server.toString() != ip || serverPort != port) { { QWriteLocker l(&mAuxiliaryInformationLock); - mServerIp = QHostInfo::fromName(ip).addresses().first(); + auto addresses = QHostInfo::fromName(ip).addresses(); + if (addresses.isEmpty()) { + QLOG_INFO() << "Not found addresses for ip " << ip; + return; + } + mServerIp = addresses.first(); mServerPort = port; } saveSettings();