Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoltan: missing target when building Albany #12371

Closed
ikalash opened this issue Oct 6, 2023 · 7 comments
Closed

Zoltan: missing target when building Albany #12371

ikalash opened this issue Oct 6, 2023 · 7 comments
Labels
client: Albany Issue impacting the Albany project pkg: Zoltan type: bug The primary issue is a bug in Trilinos code or tests

Comments

@ikalash
Copy link
Contributor

ikalash commented Oct 6, 2023

It seems that we are seeing an error related to a missing target in Zoltan when building Albany:

Call Stack (most recent call first):
  /projects/albany/nightlyCDash/build/TrilinosSerialInstall/lib64/cmake/TrilinosSS/TrilinosSSConfig.cmake:133 (include)
  /projects/albany/nightlyCDash/build/TrilinosSerialInstall/lib64/cmake/Amesos/AmesosConfig.cmake:161 (include)
  /projects/albany/nightlyCDash/build/TrilinosSerialInstall/lib64/cmake/Stratimikos/StratimikosConfig.cmake:148 (include)
  /projects/albany/nightlyCDash/build/TrilinosSerialInstall/lib64/cmake/Piro/PiroConfig.cmake:148 (include)
  /projects/albany/nightlyCDash/build/TrilinosSerialInstall/lib64/cmake/Trilinos/TrilinosConfig.cmake:123 (include)
  CMakeLists.txt:81 (find_package)


CMake Error at /projects/albany/nightlyCDash/build/TrilinosSerialInstall/lib64/cmake/Zoltan/ZoltanTargets.cmake:61 (set_target_properties):
  The link interface of target "Zoltan::zoltan" contains:

    Zoltan::m

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

https://sems-cdash-son.sandia.gov/cdash/build/52980/configure

Can someone please look into this?

@trilinos/zoltan

@ikalash ikalash added type: bug The primary issue is a bug in Trilinos code or tests pkg: Zoltan client: Albany Issue impacting the Albany project labels Oct 6, 2023
@cgcgcg
Copy link
Contributor

cgcgcg commented Oct 6, 2023

@bartlettroscoe @sebrowne Do you understand why that could be happening? Maybe this is related to #12362?

@bartlettroscoe
Copy link
Member

Yea, it is most certainly caused by:

The CMake documentation for LINK_LIBRARIES_ONLY_TARGETS did not mention that issue (but I should have realized this would happen).

@sebrowne, we should revert that PR ASASP and come up with a different solution. (And that solution will likely be a "MLib" TPL that will generate the correct targets for the installed <Package>Config.cmake files and new TriBITS already supports that use case so this will be very little CMake code.)

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Oct 6, 2023

PR:

reverts the change. Someone just needs to approve that PR and it needs to get through PR testing.

@ikalash
Copy link
Contributor Author

ikalash commented Oct 6, 2023

Thanks! I can reviews if you add me as a reviewer.

@ikalash
Copy link
Contributor Author

ikalash commented Oct 8, 2023

It looks like this has been resolved through the revert. Do you want me to keep this issue open, since I presume a different workaround from the revert is desired, or should I close it?

@ikalash ikalash closed this as completed Oct 8, 2023
@ikalash ikalash reopened this Oct 8, 2023
@bartlettroscoe
Copy link
Member

@ikalash, this was a mistake that got through Trilinos testing. It was reverted in:

I will converse with @sebrowne on how to address this property.

@ikalash
Copy link
Contributor Author

ikalash commented Oct 9, 2023

Ok I will close in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: Albany Issue impacting the Albany project pkg: Zoltan type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants