Merge pull request #892 from trimble-oss/dev/coliff/sonar-fixes

Sonar Fixes
trimble-oss · Aug 15, 2024 · 40566c8 · 40566c8
2 parents c609c78 + 876fed0
commit 40566c8
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/sonar-scan.yml b/.github/workflows/sonar-scan.yml
@@ -22,7 +22,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 

diff --git a/layouts/_default/_markup/render-heading.html b/layouts/_default/_markup/render-heading.html
@@ -5,13 +5,13 @@
   h2 mt-5 {{- end -}}
   {{- if (eq .Level 4 ) }}h4 fw-bold mt-3{{- end -}}{{ if eq .Anchor "use-when" }} h4 fw-bold text-success{{- end -}}{{ if eq .Anchor "dont-use-when" }} h4 fw-bold text-danger{{- end -}}">
   {{ if eq .Anchor "use-when" }}
-  <svg xmlns="http://www.w3.org/2000/svg" width="18" height="18" fill="currentColor" class="mx-1 mb-1"
+  <svg width="18" height="18" fill="currentColor" class="mx-1 mb-1"
     viewBox="0 0 24 24">
     <path
       d="M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2Zm5.56 7.74-6.39 6.4a1 1 0 0 1-1.42-.01l-3.3-3.34-.01-.01a.993.993 0 0 1 .01-1.4.996.996 0 0 1 1.41 0l2.6 2.62 5.68-5.69a.996.996 0 0 1 1.41 0v.02h.01c.39.39.39 1.02 0 1.41Z" />
   </svg>{{- end -}}
   {{- if eq .Anchor "dont-use-when" -}}
-  <svg xmlns="http://www.w3.org/2000/svg" width="18" height="18" fill="currentColor" class="mx-1 mb-1"
+  <svg width="18" height="18" fill="currentColor" class="mx-1 mb-1"
     viewBox="0 0 24 24">
     <path
       d="M12 2C6.47 2 2 6.47 2 12s4.47 10 10 10 10-4.47 10-10S17.53 2 12 2Zm4.3 14.3a.996.996 0 0 1-1.41 0L12 13.41 9.11 16.3a.996.996 0 1 1-1.41-1.41L10.59 12 7.7 9.11A.996.996 0 1 1 9.11 7.7L12 10.59l2.89-2.89a.996.996 0 1 1 1.41 1.41L13.41 12l2.89 2.89c.38.38.38 1.02 0 1.41Z" />
@@ -20,4 +20,4 @@
   {{ if and (ne .Anchor "use-when") (ne .Anchor "dont-use-when") }}
   <a class="header-link text-light text-decoration-none fw-normal" href="#{{- .Anchor | safeURL -}}"
     aria-label="anchor"></a>{{ end }}
-</h{{ .Level }}>
+</h{{ .Level }}>
diff --git a/layouts/_default/_markup/render-link.html b/layouts/_default/_markup/render-link.html
@@ -1,9 +1,9 @@
 {{ if strings.HasPrefix .Destination "https://brandfolder.com" }}
-  <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="opacity-75" viewBox="0 0 24 24">
+  <svg width="16" height="16" fill="currentColor" class="opacity-75" viewBox="0 0 24 24">
     <path d="M16.96 8.92V7.21c0-2.61-1.91-4.94-4.51-5.19A5.003 5.003 0 0 0 6.96 7v1.92h-1c-1.1 0-2 .9-2 2v9.07c0 1.1.9 2 2 2h12c1.1 0 2-.9 2-2v-9.07c0-1.1-.9-2-2-2zM11.97 17c-1.1 0-2-.9-2-2s.9-2 2-2 2 .9 2 2-.9 2-2 2m2.98-8.08h-6v-1.8c0-1.45.98-2.78 2.4-3.06 1.92-.37 3.6 1.09 3.6 2.94z"/>
   </svg>
   {{end}}
 <a href="{{- .Destination | safeURL -}}" {{ with .Title}} title="{{- . -}}"
   {{- end -}}{{ if strings.HasPrefix .Destination "http" }} target="_blank" rel="noopener" {{- end -}}>
   {{- .Text | safeHTML -}}
-</a>
+</a>
diff --git a/layouts/partials/related-content.html b/layouts/partials/related-content.html
@@ -32,7 +32,7 @@
         </div>
         <div class="row">
           <p class="ps-3 fw-bold text-primary">
-            Read More <svg xmlns="http://www.w3.org/2000/svg" class="ms-1" width="6.3" height="9.8"
+            Read More <svg class="ms-1" width="6.3" height="9.8"
               viewBox="0 0 6.3 9.8">
               <g transform="translate(1.412 1.412)">
                 <path id="Path_627" data-name="Path 627" d="M18,18.965l3.889-3.482L18,12" transform="translate(-18 -12)"

diff --git a/layouts/partials/trimble-logo.html b/layouts/partials/trimble-logo.html
@@ -1,4 +1,4 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="115" height="26" class="img-fluid" viewBox="0 0 444.7 100">
+<svg width="115" height="26" class="img-fluid" viewBox="0 0 444.7 100">
   <path d="M115.85 87.13v-62H93V11.21h62.57v14h-23v62z" fill="currentcolor" />
   <path
     d="M141.9 87.13V32.74h16.52v8.84h.1c3-4.62 8.21-10.26 18.47-10.26h.51V46c-.61-.11-3.49-.31-4.51-.31a18.27 18.27.0 00-14.57 7.49v34z"

diff --git a/layouts/shortcodes/card-start.html b/layouts/shortcodes/card-start.html
@@ -33,12 +33,12 @@ <h3>
           <div class="col-6">
             <iframe
               src='https://ghbtns.com/github-btn.html?user=trimble-oss&repo={{.Get "github"}}&type=star&count=true'
-              class="bg-transparent" scrolling="0" width="150" height="20" title="GitHub" loading="lazy"></iframe>
+              class="bg-transparent" width="150" height="20" title="GitHub" loading="lazy"></iframe>
           </div>
           <div class="col-6">
             <iframe
               src='https://ghbtns.com/github-btn.html?user=trimble-oss&repo={{.Get "github"}}&type=fork&count=true'
-              class="bg-transparent" scrolling="0" width="150" height="20" title="GitHub" loading="lazy"></iframe>
+              class="bg-transparent" width="150" height="20" title="GitHub" loading="lazy"></iframe>
           </div>
         </div>
         {{ end }}

diff --git a/layouts/shortcodes/ico-check.html b/layouts/shortcodes/ico-check.html
@@ -1,4 +1,4 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" class="text-success" viewBox="0 0 512 512">
+<svg width="14" height="14" class="text-success" viewBox="0 0 512 512">
   <path fill="currentColor"
     d="M0 256C0 114.6 114.6 0 256 0C397.4 0 512 114.6 512 256C512 397.4 397.4 512 256 512C114.6 512 0 397.4 0 256zM371.8 211.8C382.7 200.9 382.7 183.1 371.8 172.2C360.9 161.3 343.1 161.3 332.2 172.2L224 280.4L179.8 236.2C168.9 225.3 151.1 225.3 140.2 236.2C129.3 247.1 129.3 264.9 140.2 275.8L204.2 339.8C215.1 350.7 232.9 350.7 243.8 339.8L371.8 211.8z" />
 </svg>