Skip to content

Commit

Permalink
Merge pull request #888 from trimble-oss/dev/coliff/lint-fixes
Browse files Browse the repository at this point in the history
Lint Fixes
  • Loading branch information
coliff authored Aug 12, 2024
2 parents 79983fc + 974d5e5 commit 43d9be1
Show file tree
Hide file tree
Showing 8 changed files with 324 additions and 247 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/super-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
with:
fetch-depth: 0

- name: Lint Code Base
- name: Super-linter
uses: super-linter/super-linter/slim@v6
env:
DEFAULT_BRANCH: main
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.15.1
20.16.0
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ We are happy to accept contributions from the community to improve this project.

### Setup (for creating a build of the site locally)

These steps assume you have [NodeJS](https://nodejs.org/en/), [Git](https://git-scm.com/) and a code editor installed.
These steps assume you have [Node.js](https://nodejs.org/en/), [Git](https://git-scm.com/) and a code editor installed.

1. Install dependencies with `npm install`
2. Run `npm run serve` to run local server.
Expand All @@ -28,7 +28,7 @@ These steps assume you have [NodeJS](https://nodejs.org/en/), [Git](https://git-
- File formats: Photos should never be in PNG24. A high quality JPEG is usually 1/4 of the size
- Always specify `alt=""` for improved accessibility
- Always specify `height` and `width` to images to improve page-rendering time (reduce repaints)
- Always add `loading="lazy"` to images below the fold for native lazy-loading (not needed for images less than 4 KB)
- Always add `loading="lazy"` to images below the fold for native lazy loading (not needed for images less than 4 KB)
- Add the class `img-fluid` to images which are wider than 320 pixels so that they scale down on small screens such as iPhone 5/SE
- PNG Bitmap images should be losslessly optimized with `npm run imagemin` or <https://squoosh.app/>
- Image file size should never exceed 200 KB
Expand Down
2 changes: 1 addition & 1 deletion content/components/mobile/accordions/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Use a contained accordion for most cases. Separate its items with a divider. Thi

### Separated

There are some cases, when you can separate accordions with white space. Use this method, when you have available space.
There are some cases, when you can separate accordions with whitespace. Use this method, when you have available space.

{{< img src="/img/mobile/accordion-separated.svg" dark="/img/mobile/accordion-separated-dark.svg" width="960" height="488" alt="Separated Accordion" >}}

Expand Down
2 changes: 1 addition & 1 deletion content/components/web/tables/styles.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ There are two categories of actions available in tables:
<br><br>
{{< img src="/img/components/tables-changing-sort.svg" dark="/img/components/tables-changing-sort-dark.svg" class="w-100" alt="Changing a Sort Type" >}}
<br><br> - **Column/ Row Reordering:** - User should be able to left click and hold the column header to drag and drop the column in a new order. A visual indicator should be used between the header cells where the column will be dropped. - A separate menu for column order can be utilized in conjunction with but not without the drag and drop function. i.e. if there is a column order menu, you must also retain drag-and-drop functionality - Draggable rows should use the “Drag 2” icon located before the first cell of the table.
- **Changing Width:** - When hovering above the dividing line between two columns, there should be a visual indicator that the column is adjustable. Recommend indicator: Border becomes thicker (>2) and/or changes to the primary action color. - Auto-Fit: User should be able to double click the adjustable border in order to fit content to the column.
- **Changing Width:** - When hovering above the dividing line between two columns, there should be a visual indicator that the column is adjustable. Recommend indicator: Border becomes thicker (>2) and/or changes to the primary action color. - Auto-Fit: User should be able to double-click the adjustable border in order to fit content to the column.
- **Hiding/ Showing Columns:** - Right clicking on a column header should give the user a context menu option to collapse/show columns. When a column is collapsed, the border between headers should be increased to 3px. Single clicking the visual indicator will show the column. Right clicking the visual indicator will open the context menu. - Unless use case dictates, Hiding a column does NOT “deactivate” a column and its content. Meaning that even though a column is hidden, the table will still use its content in filters, groups, sorts, etc.
- **Changing Views:** A view is a default or custom table layout that is saved based on the user’s last selection. User should have a way to reset a view and/or to choose from a list of default views.
- **Global Search:** - Search field should be located above the table header and/or collocated with any horizontal toolbar. - Search field should use the Modus “Input with icon on left,” and utilize the magnifying glass icon. - Once a string is entered, the “content close” icon should appear at the right internal edge of the field, allowing the user to cancel the search / delete the string. - App Specific: It is at the product team's discretion to update the table real time as a string is entered or after a return. - Optional: Magnifying glass icon can be used on its own, upon a user clicking the icon it should expand into the input field state prescribed above.
Expand Down
2 changes: 1 addition & 1 deletion content/news/2021-04-15-usability-inspection-methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ There are many ways that you can write your results from doing a CW. One common

![Results Example](/img/news/usability-inspection-6.jpg)

## What if I want to mix parts of both methods HE and CW? Is that ok?
## What if I want to mix parts of both methods HE and CW? Is that OK?

Of course! You can mix any usability inspection method. And to be honest, you will notice that it comes naturally. For example, you can do a HE, while going through a sequence of actions. You can also do a HE imagining the user is going through this task for the very first time. This can help you to determine the scope for a HE. On the other hand, you can explain certain issues from the CW by providing the violated heuristics to better understand the issue and how to potentially fix them.

Expand Down
Loading

0 comments on commit 43d9be1

Please sign in to comment.