From e919541d15c42739b3d7b24ec6fc231233651d23 Mon Sep 17 00:00:00 2001 From: Andrii Rosa Date: Thu, 5 Jan 2023 13:11:45 -0500 Subject: [PATCH] Do not override heapHeadroomPerNode by default Trino sets the headroom to 30% of heap by default. Overriding it to 1GB is error prone, as somebody may increase the heap size without adjusting the headroom. --- charts/trino/README.md | 4 ++-- charts/trino/values.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/trino/README.md b/charts/trino/README.md index 422c8af4..1f800fc4 100644 --- a/charts/trino/README.md +++ b/charts/trino/README.md @@ -59,7 +59,7 @@ The following table lists the configurable parameters of the Trino chart and the | `coordinator.jvm.maxHeapSize` | | `"8G"` | | `coordinator.jvm.gcMethod.type` | | `"UseG1GC"` | | `coordinator.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` | -| `coordinator.config.memory.heapHeadroomPerNode` | | `"1GB"` | +| `coordinator.config.memory.heapHeadroomPerNode` | | `""` | | `coordinator.additionalJVMConfig` | | `{}` | | `coordinator.resources` | | `{}` | | `coordinator.livenessProbe` | | `{}` | @@ -67,7 +67,7 @@ The following table lists the configurable parameters of the Trino chart and the | `worker.jvm.maxHeapSize` | | `"8G"` | | `worker.jvm.gcMethod.type` | | `"UseG1GC"` | | `worker.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` | -| `worker.config.memory.heapHeadroomPerNode` | | `"1GB"` | +| `worker.config.memory.heapHeadroomPerNode` | | `""` | | `worker.additionalJVMConfig` | | `{}` | | `worker.resources` | | `{}` | | `worker.livenessProbe` | | `{}` | diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml index 3f2ca686..3b79e737 100644 --- a/charts/trino/values.yaml +++ b/charts/trino/values.yaml @@ -162,7 +162,7 @@ coordinator: config: memory: - heapHeadroomPerNode: "1GB" + heapHeadroomPerNode: "" additionalJVMConfig: {} @@ -201,7 +201,7 @@ worker: config: memory: - heapHeadroomPerNode: "1GB" + heapHeadroomPerNode: "" additionalJVMConfig: {}