Add Client Tags Support #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need this in order to properly ingest metrics from the event APIs! Would love to see it merged, let me know if there's anything I can do to help expedite. |
nineinchnick
reviewed
Sep 3, 2025
Flgado
force-pushed
the
add_tags_support
branch
from
8a9247e to
5f131da
Compare
nineinchnick
approved these changes
Sep 29, 2025
Flgado
force-pushed
the
add_tags_support
branch
from
5f131da to
8c2bfb9
Compare
nineinchnick
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
X-Trino-Client-Tagsheader to be pass as connection url.The
X-Trino-Client-Tagsheader is part of the official Trino client protocol and allows sending a comma-separated list of tags. These tags can be used for resource management, query monitoring, and routing rules.This Pr also add integration tests to
X-Trino-Client-Tagsheader when is passed as NamedArgTesting
Integration tests ensure that Trino correctly receives the tags by checking the query status and validating that the tags sent are the ones set for that query session.
Motivation
This feature was requested by the community in issue #121 and is also needed by grafana-trino#309 that depends on trino go client (so is good to have integration tests making sure is working properly .