Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable prepared statements by default #306

Closed
1 task done
damian3031 opened this issue Dec 22, 2022 · 3 comments
Closed
1 task done

Disable prepared statements by default #306

damian3031 opened this issue Dec 22, 2022 · 3 comments
Assignees

Comments

@damian3031
Copy link
Member

Describe the feature

Disable prepared statements by default.
Exact approach and details about implementation could be discussed in the comments.

Describe alternatives you've considered

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@damian3031
Copy link
Member Author

In this draft PR #310 3 possible approaches of handling this issue were presented. All of them were thoroughly discussed. As a result, we decided that the best approach is nr 3 - transporting prepared statement parameters in the JSON body instead of the headers. It will fix biggiest issue here - hitting header limit size by query. Query will be still parsed by SQL parser on Trino side, as opposed to approach nr 2.

Due to the low priority and high complexity of this issue, it is currently on hold.

@aalbu
Copy link
Member

aalbu commented Apr 10, 2024

@hashhar, can we close this issue? Based on comments in the referenced PR, it seems like the the main problem it's attempting to address is the header size limitations for prepared statements. At this point, we have a way to avoid passing prepared statement parameters in the header, but specifying legacy_prepared_statements=False.

@hashhar
Copy link
Member

hashhar commented Apr 15, 2024

Yes, I think this is no longer as relevant because of EXECUTE IMMEDIATE.

We can revisit if there's still interest in this.

@hashhar hashhar closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants