Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SQLAlchemy 2.x #407

Closed
1 task
hongbo-miao opened this issue Sep 9, 2023 · 2 comments
Closed
1 task

Support SQLAlchemy 2.x #407

hongbo-miao opened this issue Sep 9, 2023 · 2 comments

Comments

@hongbo-miao
Copy link

hongbo-miao commented Sep 9, 2023 •
edited
Loading

Describe the feature

In the readme, it says

trino.sqlalchemy is compatible with the latest 1.3.x and 1.4.x SQLAlchemy versions at the time of release of a particular version of the client.

It would be great to support SQLAlchemy 2.x, thanks! ☺️

Describe alternatives you've considered

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@hovaesco
Copy link
Member

It's already being tested with SQLAlchemy 2.0.x, I will update the README.

@hashhar
Copy link
Member

hashhar commented Sep 13, 2023

Fixed in #409

@hashhar hashhar closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hongbo-miao @hashhar @hovaesco