Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTER TABLE - event-listener records don't provide the table name #24537

Open
bhzaeri opened this issue Dec 20, 2024 · 9 comments
Open

ALTER TABLE - event-listener records don't provide the table name #24537

bhzaeri opened this issue Dec 20, 2024 · 9 comments

Comments

@bhzaeri
Copy link

bhzaeri commented Dec 20, 2024

When a table is altered by the ALTER TABLE command (column added, dropped, or renamed), the table names are not included in the triggered events received in the queryCompleted method of the io.trino.spi.eventlistener.EventListener interface.
All of these are empty:

queryCompletedEvent.getMetadata().getTables()
queryCompletedEvent.getIoMetadata().getInputs()
queryCompletedEvent.getIoMetadata().getOutput()

This is an example of the SQL alter command:
alter table sqlserver_sa.dbo.persons add column zip varchar

@mosabua
Copy link
Member

mosabua commented Dec 20, 2024

Can you verify if the info shows up in the web UI please

@bhzaeri
Copy link
Author

bhzaeri commented Dec 20, 2024

Yes, I see the events in the web ui.

@mosabua
Copy link
Member

mosabua commented Dec 20, 2024

Great is the table info there also missing?

@bhzaeri
Copy link
Author

bhzaeri commented Dec 20, 2024

This is what I'm seeing. It looks okay.
Image

@ebyhr
Copy link
Member

ebyhr commented Dec 20, 2024

@mosabua You can simply reproduce this issue with OpenLineageListenerQueryRunner.

@Praveen2112
Copy link
Member

I think we don't support capturing events for ALTER events.

@bhzaeri
Copy link
Author

bhzaeri commented Dec 27, 2024

@Praveen2112 Raising events for ALTER events is supported. I see them in the event listeners. But the table and schema names are empty.

@moritzia
Copy link

moritzia commented Feb 1, 2025

@mosabua I also found in Alter, there is no tablename.

@Override
 public void queryCompleted(QueryCompletedEvent event) {

     // Capture input tables and columns
     List<QueryInputMetadata> inputs = event.getIoMetadata().getInputs();
     for (QueryInputMetadata input : inputs) {
         System.out.println("Input Table: " + input.getSchema() + "." + input.getTable());
.....

How can we reach to table name and column name in alter statement?

@mosabua
Copy link
Member

mosabua commented Feb 6, 2025

Looks like this is a valid issue. I am not aware of anybody working on it so maybe you want to have a look at fixing that and sending a PR @moritzia ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants