Add docs for OPA access control #20246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
opa-docs
branch
2 times, most recently
from
eba8822
to
398708f
Compare
mosabua
force-pushed
the
opa-docs
branch
2 times, most recently
from
d437f63
to
5c0e10c
Compare
sbernauer
suggested changes
Jan 4, 2024
vagaerg
reviewed
Jan 9, 2024
vagaerg
reviewed
Jan 9, 2024
There was a problem hiding this comment.
LGTM other than the minor nitpick
Will work shortly on merging our work in https://github.com/bloomberg/trino/tree/add-open-policy-agent-with-docs/plugin/trino-opa/schema-docs here
That contains examples and full documentation for each operation
We've also built some JSON Schemas we could share, but that's potentially out of scope for this
|
I fixed the nit and will leave PR as is for now. Lets see when we get the code PR merged. Then we can adjust the docs to the same level and add more later. |
mosabua
changed the title
|
This looks good. I think we should remove duplicate stuff from the readme, so we don't have two places to maintain. |
dain
changed the title
dain
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting readme from code PR into docs output and updating wording, grammar, content, and so on.
It would be great to have a few very simple rego scripts as example. Something like read only access for everyone, read only for specific catalogs only and users and groups, and maybe one or two more .. and then link to the relevant sections in the OPA docs for more. Any tips @vagaerg or @sbernauer ?
Additional context and related issues
#19532
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
Release notes entry comes from code PR.