Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap not displaying correctly #301

Open
martacds opened this issue Jun 11, 2019 · 10 comments · Fixed by #302
Open

Heatmap not displaying correctly #301

martacds opened this issue Jun 11, 2019 · 10 comments · Fixed by #302
Assignees

Comments

@martacds
Copy link

Hi!
I placed the heatmap without any problems but it displays like this:
Capture33

I have the same heatmap displaying correctly on another place.
Capture34

How do I fix this?
Thank you!

@martacds
Copy link
Author

Hi,
Figured out what was wrong! A few of the BioSample names were too long so it deformed the heatmap even when they weren't on display.

May I suggest a warning about this or an update so that one single BioSample name doesn't deform the heatmap for all analyses?

Thanks anyway!

@almasaeed2010 almasaeed2010 self-assigned this Jun 12, 2019
@almasaeed2010
Copy link
Contributor

Hello @martacds

Thanks for reporting the issue (and the fix!). I'll try to add in some code to trim the names when I get a chance.

Thanks!

almasaeed2010 added a commit that referenced this issue Jun 12, 2019
almasaeed2010 added a commit that referenced this issue Jun 12, 2019
@almasaeed2010
Copy link
Contributor

Issue has been fixed on master. Please feel free to re-open the issue if the fix doesn't help.

Thanks!

@martacds
Copy link
Author

So it fixed the space the name occupies by putting it horizontally and clipping the excess but the heatmap still gets smaller.
Screenshot from 2019-06-12 14-09-19

In the example, I added a bunch of XXs at the end of the first BioSample (which has the longest name) and the heatmap got progressively smaller despite the fix.

@almasaeed2010 almasaeed2010 reopened this Jun 12, 2019
@almasaeed2010
Copy link
Contributor

This seems like an issue with JS library that generates the heatmap. Could you try resizing your browser window? Resizing the window should prompt it to redraw the map and recalculate the space needed. If the map is fixed after resizing, then we can make sure it reset the height prior to drawing the first time.

@martacds
Copy link
Author

I tried maximizing and minimizing the window (I assume that's what you meant) and it's still not right.

The previous screenshot I sent had a small window and after maximizing it showed up like this:
Screenshot from 2019-06-12 14-19-08

@almasaeed2010
Copy link
Contributor

Sorry I meant resizing the browser window by making the width of the window smaller or larger (dragging the edge of the window using the mouse).

@martacds
Copy link
Author

Yes, I did that. It looks the same as before.

@almasaeed2010
Copy link
Contributor

Hmmm. Can you share a sample of your dataset? It'll help us replicate the issue. Thanks!

@martacds
Copy link
Author

All I did was use a previous dataset and edit the BioSample name. I added a bunch of XXXs to the BioSample name to make it really long (it currently has the following name: "Embryos ; S1 to S8 [from fruit] xxxxxxxxxxxxxxxxxxxxxxxxxx").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants