Replies: 1 comment 2 replies
-
Hey! As you may know, we are rewriting the backend, and will temporarily drop references to the AMD runtime there. It will be readded when codegen for AMD hardware also happens (it's not in the short term plans for now). In the meantime, i think it's wise to keep it in the main repo for future reference. Also, runtimes in Triton are handled by dynamically loading shared objects, so #ifdefs shouldn't be necessary. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
At the moment Triton uses the partially copied header(s)
triton/include/triton/external/hip.h
from HIP/ROCm. It seems it would be better to#include <hip/hip_runtime_api.h>
(points to/opt/rocm/hip/hip_runtime_api.h
).But Triton should be able to build without installed ROCm so I see two main approaches to implement the functionality:
#if defined(USE_ROCM)
but I'm not sure it will be possible without paintriton/include/triton/external/hip.h
) in case Triton is built without ROCm support. E.g.:@ptillet @micmelesse what do you think?
Beta Was this translation helpful? Give feedback.
All reactions