-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support blocked dot operand layout conversion to linear layout #5423
Comments
+cc @simonidaa |
+@lezcano Maybe you can offload this to AMD? Or there's something you've already done but not pushed yet? |
@binarman btw, something related, we plan to completely abandon the |
Thank you @Jokeren! this is good to know, I will consider removing |
Very good to hear for this work! (For my experimental project, using LL for non-GPUs, yeah, this was a missing feature. I hacked badly just to make it passable for unit tests, but looking forward to seeing this support.) |
I did not start with this, so feel free to take over. |
@lezcano told me this task is blocking him, so I am going to implement it asap, |
I've made a draft PR: #5469 |
Goal
Support FMA/Blocked dot operand layout in linear layout converter.
DoD
Implemented LinearLayout converter and related tests are implemented and passing, switch to Linear layout converter do not break python tests.
Existing Linear Layout converters for dot operands
Nvidia MMA dot operand
AMD MFMA dot operand
Both of these examples are fully functional, but I want to refactor MFMA and WMMA converters in similar to Nvidia MMA fashion soon. Please try to follow MMA style.
In progress PRs
WMMA dot operand
Legacy SharedLayout->dotOperand converter examples
Implementation details
shared->blocked dotOperand
conversion with LL; check alltest_core.py
tests work.ttg.convert_layout
operation conversion with LL. Maybe you need to rework some other places as well, we will clarify this during implementation.ctest
tests in LinearLayoutConversionsTest.cpp and few lit tests to specifically verifyttg.convert_layout
operation conversionThe text was updated successfully, but these errors were encountered: