-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export DataFrames
, CSV
and JSON
?
#407
Comments
Since each additional exported package may cause naming conflict with a user's REPL session, I would advise against it. Especially since for a regular user, it is then no longer clear that some of the functionality they use are actually from other packages and not TrixiParticles.jl itself. |
Do you have any other suggestions then? It's extremely annoying when a new user wants to run one of these examples and gets 5 consecutive errors that a package is missing. |
I'd say proper documentation is key. In each example you give, all the necessary If it turns out that there are certain postprocessing steps that could benefit from wrapping them in a high-level function in TrixiP, you might do that and only export the high-level function. Another alternative is that you don't just export whole packages, but if there's, e.g.,. just 2-3 types/functions from DataFrames that a user might want to have available, you could just export those (like we do with |
The We need |
In Trixi.jl we have a similar issue and we solved it by modifying the installation instructions, saying that for postprocessing you may want to install the following, additional pacakges using something like |
In the postprocessing example, and also in all the validation example files that will follow, we do
using DataFrames, CSV, JSON
all of which are also dependencies of TrixiParticles.
Would it make sense to re-export these names, so that users don't have to add a lot of extra packages to the
run
environment to run these files?@sloede ?
The text was updated successfully, but these errors were encountered: