Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce additional abstraction layer for the SWE/SWEWD to reduce code duplication #24

Open
patrickersing opened this issue Mar 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@patrickersing
Copy link
Contributor

We currently have to duplicate some functionality, that is already implemented in Trixi.jl, such as for example the FluxHLL.
As discussed here it could be a good idea to introduce an additional abstraction layer to minimize the code duplication e.g. a function

@inline function (numflux::FluxHLL)(u_ll, u_rr, orientation_or_normal_direction,
                                    equations::AbstractShallowWaterEquations{NDIMS})

that works for both the SWE in Trixi.jl and the SWEWD in TrixiShallowWater.jl.

However, when introducing this we need to be careful that these functions work for all sub-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant